Exclude copy button from notebook cell numbers #1811
Conversation
Coverage report
This PR does not seem to contain any modification to coverable code. |
trallard
added
the
tag: component
|
As I was about to merge, I thought, that since the change is in docs/conf.py (our documentation site configuration file this will only fix the issue for our docs. Shall we add a note in our docs aimed at users so they know that if they are using notebooks to generate content like this they have to add this configuration to their own |
|
Oh, that's a good catch. Will need to give this a rethink |
|
In the short term, I decided to add a note to the docs for end users. For the longer term, I will look into filing an issue or pull request with nbsphinx. For our end users, the ideal situation is for things to "just work" so they don't have to do extra config to make nbsphinx and Sphinx-copybutton play nicely together. |
|
Agree! I think this short-term fix should suffice for now but ideally this will be something that just works for users long-term |
* Exclude copy button from notebook cell numbers * Update docs/conf.py * Add note in docs about Sphinx-copybutton and nbsphinx
Because of the way nbsphinx renders notebook cells and the way that Sphinx-copybutton targets code blocks, the line numbers next to notebook cells were getting the copy button, as the following screenshot shows:
This PR changes the copy button selector to exclude the notebook cell line numbers.
Note: the default copy button selector is
div.highlight pre