Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the back_to_top_button config option #1843

Merged
merged 3 commits into from
May 30, 2024

Conversation

melissawm
Copy link
Contributor

Closes #1842

Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one question inline

Comment on lines 52 to 55
```

```{toctree}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the extra empty TOCtree necessary here? I'd expect it to be OK without:

Suggested change
```
```{toctree}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is weird, I'm sorry - not sure where that came from.

Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! I figured it was an unintended copy/paste or something, just wanted to make sure.

+1 for merge when CIs are green.

@drammock drammock merged commit 276bfbf into pydata:main May 30, 2024
30 checks passed
@drammock
Copy link
Collaborator

thanks @melissawm!

ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
* Add documentation for the back_to_top_button config option

* [pre-commit.ci] Automatic linting and formatting fixes

* Remove spurious toctree

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document "Back to top" button behavior
2 participants