A11Y: Add title attribute to theme switcher #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
gabalafou
previously requested changes
Jul 18, 2024
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/theme-switcher.html
Outdated
Show resolved
Hide resolved
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/theme-switcher.html
Outdated
Show resolved
Hide resolved
Yep, sounds good, I'm usually bad at narative and text bing @isabela-pf for the text |
|
After merging #1921, this now has conflicts |
|
No worries, I'll rebase. |
gabalafou
requested changes
Aug 19, 2024
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/theme-switcher.html
Outdated
Show resolved
Hide resolved
This will add a `<title>` attribute to the SVG generated by font
awesome, which will in turn update the Accessibility tree, which will
now be
- button "light/dark" focusable: true focused: bool
- image: $title-text
Should fix Quansight-Labs/czi-scientific-python-mgmt#76
trallard
added
kind: enhancement
gabalafou
approved these changes
Aug 21, 2024
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a
<title>attribute to the SVG generated by font awesome, which will in turn update the Accessibility tree, which will now beShould fix Quansight-Labs/czi-scientific-python-mgmt#76