Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom logo and fab option #261

Closed
wants to merge 3 commits into from

Conversation

brbarkley
Copy link

Building on #213, which actually enables compatibility of the Edit this page feature with non-GitHub platforms (not just GitHub Enterprise instances), this PR enables a GitLab fab in the top-right corner.

In addition, it enables users to add a secondary logo in the right sidebar below the Edit this page link, which is nice for additional branding.

@brbarkley
Copy link
Author

Hello, upon closer inspection of recent commits and PRs, it is now possible/easier to customize the sidebar with pydata-sphinx-theme's built-in html_theme_options given improvements in #248.

And while customizing the github fab image is not possible with pydata-sphinx-theme's built-in html_theme_options, I managed to figure out how to change the fab image using sphinx's custom templating, specifically extending docs_navbar.

So, I am closing this PR. However, it would be great to see recent commits, namely #248, pushed to a new PyPi release.

Thanks again for this beautiful sphinx theme!

@brbarkley brbarkley closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant