-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ ENH: Collapsible sections in the sidebar #349
Conversation
The demo site shows the basics are working: https://pydata-sphinx-theme--349.org.readthedocs.build/en/349/demo/demo.html |
I think it looks great! We should probably add a few more nested levels here and there in the docs to see how the arrows look (e.g., 2 levels deep, or two nested levels right next to each other, etc). I've just upgraded to the pydata v0.5 theme in the sphinx book theme: executablebooks/sphinx-book-theme#312 once we get this merged and released, I will remove this section of that theme as well 🎉 |
I added some more nested pages in the demo docs, and after some fixes, that's looking good now! |
Awesome, this is looking great. What do you think about adding a lightweight UX to show when people are hovering over the arrow? Something like ul.bd-sidenav label:hover {
background: #e4e4e4;
} |
except not hardcoded... |
lol sorry that was my "minimal viable github issue product" 🙃 |
Is this something you would like to add to sphinx-book-theme as well? (I mimicked that look for now) Adding a more prominent area hover color might indeed be good. It's also what Furo does (although Furo also does that for the titles in the sidebar) |
OK, I added a hover background color controlled by a new CSS variable. |
Woohoo, this will also be great to use in the pandas docs! |
Coooooooooooool~! |
Very much a draft PR, but putting it here to show what I experimented with a while ago.
This basically is a copy the CSS approach (and code) from Furo. I initially started with trying the approach from the sphinx-book-theme, but for some reason (probably just something small), I didn't get the javascript working for that.
We need to decide which approach to use, and then also a lot to clean-up in the PR.