-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making expandable/collapsible sidebar navigation + navigation depth configurable #386
Making expandable/collapsible sidebar navigation + navigation depth configurable #386
Conversation
When having a site with many files and/or many levels, this can cause a long | ||
build time and larger HTML file sizes. Therefore, it is possible to turn off | ||
the expandable navigation by setting the `collapse_navigation` config option | ||
to True: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels a bit strange to say you can turn off the expandable navigation by setting an option to True (and in general "collapse" doesn't necessarily indicate that the actual HTML is trimmed), but "collapse_navigation" is consistent with RTD and consistent with sphinx' own terminology of collapse=True/False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a minor nitpick I think this is good to go
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Thanks! |
Sorry if this is silly, my html skills are basic. But, would it be technically possible to use some JS to link to the common sidebar html files? We could then reduce the size of the individual html files in case of huge sidebars. |
@tupui see also my comments at #381 (comment) and #364. Let's maybe discuss further in #364 |
Partly addressing #381, in a sense that this makes it easier to turn off the expandable navigation sidebar, and thus you can get back to the behaviour (and performance) of 0.5.2, while having the other enhancements of 0.6.0