Hard dependency on scipy.sparse? #3
Comments
|
I think I started out as a soft dependency but transitioned to hard. Tensordot and reductions currently depend on scipy.sparse. These are important to me at the moment, but I can imagine that yes, they might not be important to all applications. |
|
Makes sense. In that case there's an extra scipy import that you could remove in |
|
fixed in d553026 |
DavidMertz
pushed a commit
to ContinuumIO/sparse
that referenced
this issue
May 9, 2017
# This is the 1st commit message: # This is a combination of 3 commits. # This is the 1st commit message: # This is a combination of 3 commits. # This is the 1st commit message: # This is a combination of 4 commits. # This is the 1st commit message: Add @ operator (__matmul__ and __rmatmul__) and tests. Do not implem ent coersion of Python lists/tuples. # This is the commit message pydata#2: test for __rmatmul__ # This is the commit message pydata#3: Better implementation of __rmatmul__ and test that exercises the actual code, not NumPy's # The commit message pydata#4 will be skipped: # Cleanup tests of coersion failure # The commit message pydata#2 will be skipped: # # This is a combination of 2 commits. # # This is the 1st commit message: # # Resolve merge conflict in rebasing # # # The commit message pydata#2 will be skipped: # # # test for __rmatmul__ # The commit message pydata#3 will be skipped: # Resolve merge conflict in rebasing # The commit message pydata#2 will be skipped: # test for __rmatmul__ # The commit message pydata#3 will be skipped: # Better implementation of __rmatmul__ and test that exercises the actual code, not NumPy's # This is the commit message pydata#2: Remove handling of lists etc. # The commit message pydata#3 will be skipped: # Remove handling of lists etc.
DavidMertz
pushed a commit
to ContinuumIO/sparse
that referenced
this issue
May 9, 2017
# This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: Resolve merge on rebase # The commit message pydata#2 will be skipped: # Resolve merge on rebase # The commit message pydata#2 will be skipped: # Better implementation of __rmatmul__ and test that exercises the actual code, not NumPy's # The commit message pydata#2 will be skipped: # Remove handling of lists etc. # The commit message pydata#3 will be skipped: # Remove handling of lists etc.
DavidMertz
pushed a commit
to ContinuumIO/sparse
that referenced
this issue
May 9, 2017
# This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: # This is a combination of 5 commits. # This is the 1st commit message: # This is a combination of 3 commits. # This is the 1st commit message: # This is a combination of 3 commits. # This is the 1st commit message: # This is a combination of 3 commits. # This is the 1st commit message: # This is a combination of 4 commits. # This is the 1st commit message: Add @ operator (__matmul__ and __rmatmul__) and tests. Do not implem ent coersion of Python lists/tuples. # This is the commit message pydata#2: test for __rmatmul__ # This is the commit message pydata#3: Better implementation of __rmatmul__ and test that exercises the actual code, not NumPy's # The commit message pydata#4 will be skipped: # Cleanup tests of coersion failure # The commit message pydata#2 will be skipped: # # This is a combination of 2 commits. # # This is the 1st commit message: # # Resolve merge conflict in rebasing # # # The commit message pydata#2 will be skipped: # # # test for __rmatmul__ # The commit message pydata#3 will be skipped: # Resolve merge conflict in rebasing # The commit message pydata#2 will be skipped: # test for __rmatmul__ # The commit message pydata#3 will be skipped: # Better implementation of __rmatmul__ and test that exercises the actual code, not NumPy's # This is the commit message pydata#2: Remove handling of lists etc. # The commit message pydata#3 will be skipped: # Remove handling of lists etc. # The commit message pydata#2 will be skipped: # # This is a combination of 3 commits. # # This is the 1st commit message: # # This is a combination of 2 commits. # # This is the 1st commit message: # # # This is a combination of 2 commits. # # This is the 1st commit message: # # Resolve merge on rebase # # # The commit message pydata#2 will be skipped: # # # Resolve merge on rebase # # # The commit message pydata#2 will be skipped: # # # Better implementation of __rmatmul__ and test that exercises the actual code, not NumPy's # # # The commit message pydata#2 will be skipped: # # # Remove handling of lists etc. # # # The commit message pydata#3 will be skipped: # # # Remove handling of lists etc. # The commit message pydata#3 will be skipped: # Resolve merge on rebase # The commit message pydata#4 will be skipped: # Resolve merge on rebase # The commit message pydata#5 will be skipped: # Resolve merge on rebase # The commit message pydata#2 will be skipped: # Better implementation of __rmatmul__ and test that exercises the actual code, not NumPy's # The commit message pydata#2 will be skipped: # Remove handling of lists etc. # The commit message pydata#3 will be skipped: # Remove handling of lists etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like you import scipy.sparse both locally and globally. I'd probably lean toward locally, to make scipy a soft dependency.
The text was updated successfully, but these errors were encountered: