Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__array_function__ test coverage; numpy 1.17; result_type() #272

Merged
merged 8 commits into from
Aug 12, 2019

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Aug 11, 2019

  • Support for numpy 1.17 (it's already what's used in CI today)
  • Implement sparse.result_type + unit tests
  • Refactor environment variables and other switches into sparse.settings
  • Add unit tests for mixed numpy+sparse inputs to __array_function__, with different permutations

@codecov
Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #272 into master will increase coverage by 0.05%.
The diff coverage is 92%.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   94.73%   94.78%   +0.05%     
==========================================
  Files          14       15       +1     
  Lines        1955     1976      +21     
==========================================
+ Hits         1852     1873      +21     
  Misses        103      103

@hameerabbasi
Copy link
Collaborator

I added a nice test for NEP-18 here: dask/dask#4675. Would you care to copy that one, as it tests the protocol?

@crusaderky
Copy link
Contributor Author

@hameerabbasi done

@hameerabbasi
Copy link
Collaborator

Can you change the implementation of result_type to the following:

return np.result_type(*(x.dtype if isinstance(x, SparseArray) else x for x in args)

And move it to common.py?

@crusaderky crusaderky changed the title __array_function__ test coverage; numpy 1.17 __array_function__ test coverage; numpy 1.17; result_type() Aug 12, 2019
@crusaderky
Copy link
Contributor Author

All done, see if you like it

@hameerabbasi hameerabbasi merged commit 1d666d1 into pydata:master Aug 12, 2019
@crusaderky crusaderky deleted the numpy117 branch August 13, 2019 00:00
@dcherian dcherian mentioned this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants