-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__array_function__ test coverage; numpy 1.17; result_type() #272
Conversation
Don't test stack() with mixed inputs Mark failures for where()
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 94.73% 94.78% +0.05%
==========================================
Files 14 15 +1
Lines 1955 1976 +21
==========================================
+ Hits 1852 1873 +21
Misses 103 103 |
I added a nice test for NEP-18 here: dask/dask#4675. Would you care to copy that one, as it tests the protocol? |
@hameerabbasi done |
Can you change the implementation of result_type to the following:
And move it to common.py? |
All done, see if you like it |
__array_function__
, with different permutations