-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset.copy() drops encoding #1586
Comments
By looking at the code, copy() is the only case where it is proper to pass the encoding to _construct_direct, but somebody please confirm |
I think this was intentional at one point, but to be honest we never carefully defined the semantics for preserving My original thought (along the lines of some of my comments in #1297), was that we should not propagate That said, I can see why this rule would be confusing and we haven't done a good job of enforcing it. Possibly a better policy would be " |
I agree that we haven't done a good job defining how |
Can we reach a resolution on this? It's blocking #1551... |
@crusaderky - After thinking about it, I'm still a 👍 on copying the encoding in this case. |
I'm OK copying encoding, but we do still need to figure out general rules for propagating it. |
This reverts commit f99313c.
* Load non-index coords to memory ahead of concat * Update unit test after #1522 * Minimise loads on concat. Extend new concat logic to data_vars. * Trivial tweaks * Added unit tests Fix loads when vars are found different halfway through * Add xfail for #1586 * Revert "Add xfail for #1586" This reverts commit f99313c.
By looking at dataset.py, there's a lot of calls to
Dataset._construct_direct
that omit the encoding. Is it correct to add it in all cases?The text was updated successfully, but these errors were encountered: