-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to parse more backend_kwargs when opening via PydapDataStore (e.g. output_grid) #6274
Labels
Comments
That sounds reasonable - are you up to create a PR? |
Yes, I can create a PR. Thanks for your fast reply. |
jgliss
pushed a commit
to jgliss/xarray
that referenced
this issue
Feb 15, 2022
4 tasks
aurghs
pushed a commit
that referenced
this issue
Feb 17, 2022
* propose implementation of #6274 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * minor fix * Add tests for new method PydapDataStore._update_default_params * minor fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add entry in whats-new.rst * Minor change * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Define open_dataset_params for cleaner solution * remove import of inspect lib * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update xarray/backends/pydap_.py Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> * update whats-new * Set pydap backend arguments explicitly * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * set defaults in PydapDataStore.open rather than entry point * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Jonas Gliss <jonas.gliss@statkraft.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
I am planning to use xarray to access netcdf data from a thredds server. For my particular application, I need to be able to set pydap client option
output_grid=False
, to avoid some issues that I have experienced with a particular dataset on the server I am downloading from.I use
xarray.open_dataset
to access the data via pydap backend, which currently only allows to specify "session" as a keyword inbackend_kwargs
.xarray/xarray/backends/pydap_.py
Line 89 in 8c5c230
It would be helpful to be able to provide additional
backend_kwargs
accepted by the pydap client (such asoutput_grid
).https://github.com/pydap/pydap/blob/dbe9b8d15831f21c28b97ed5661b2708faec45f2/src/pydap/client.py#L58
Describe the solution you'd like
It could be perhaps as simple as extending the signature of PydapDataStore.open from:
to, e.g.:
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: