Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seaborn import to toy weather data example. #1945

Merged
merged 12 commits into from
Feb 27, 2018

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Feb 27, 2018

It looks like this got inadvertently removed with the flake8 fix in #1925.

Fixes GH1944

It looks like this got inadvertently removed with the flake8 fix in GH1925.
@@ -2,6 +2,8 @@
import numpy as np
import pandas as pd

import seaborn as sns # pandas aware plotting library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F401 'seaborn as sns' imported but unused

@pydata pydata deleted a comment from stickler-ci Feb 27, 2018
@shoyer
Copy link
Member Author

shoyer commented Feb 27, 2018

I have finally banished Stickler-CI from our docs successfully!

@shoyer
Copy link
Member Author

shoyer commented Feb 27, 2018

@jhamman any objections here?

@jhamman
Copy link
Member

jhamman commented Feb 27, 2018

None.

@shoyer shoyer merged commit fd2e542 into pydata:master Feb 27, 2018
shoyer added a commit that referenced this pull request Feb 28, 2018
* Add seaborn import to toy weather data example.

Fixes GH1944

It looks like this got inadvertently removed with the flake8 fix in GH1925.

* Tweak stickler config

* Tweak stickler again

* temp tweak

* more tweaking of config

* more config tweak

* try again

* once again

* alt disable

* add comment

* final line break
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

building doc is failing for the release 0.10.1
3 participants