Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for failing zarr test #1980

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Fix for failing zarr test #1980

merged 1 commit into from
Mar 12, 2018

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Mar 10, 2018 •
edited
Loading

@jhamman jhamman requested a review from rabernat March 10, 2018 20:00
@jhamman
Copy link
Member Author

jhamman commented Mar 10, 2018

Note that this test was only failing for python 2.7 on linux. It was just a string comparison issue which seems to have been resolved by doing a more exact comparison of compressor attributes.

@shoyer shoyer merged commit aa83d0e into pydata:master Mar 12, 2018
@shoyer
Copy link
Member

shoyer commented Mar 12, 2018

Looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabernat rabernat Awaiting requested review from rabernat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhamman @shoyer