Dataset.copy docstring matches behavior

[georgegeddes]

• Closes Dataset.copy docstring has a typo #2490

This makes the docstring of Dataset.copy match the actual behavior.

However, I noticed that DataArray.copy has the opposite behavior for the deep keyword. Is this intentional, or are they supposed to behave the same way?

[pep8speaks]

Hello @georgegeddes! Thanks for submitting the PR.

• There are no PEP8 issues in the file xarray/core/dataset.py !

[shoyer]

thanks for catching this!

I'm trying to remember if there is any good reason for these methods having different defaults....

I suppose it could make sense if Dataset.copy() is modeled off dict.copy() (which does shallow copies) and DataArray.copy() is modeled off numpy.ndarray.copy() (which does deep copies).

[dcherian]

Thanks!