-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipping variables in datasets that don't have the core dim #2674
Conversation
cc @fujiisoup The challenge here is that this logic depends on the nature of the function. It only makes skip variables if applying the operation to a scalar returns the scalar. This is true for many but not all reductions, and there are lots of edge cases, e.g.,
So this really needs to be opt-in only, and even then I'm not sure it's worth the trouble. It might be better to explicitly define functions even in the case of Actually, it isn't documented behavior but
|
Thanks a lot for the comments @shoyer , that's v clarifying Is there a conceptual overlap between the goals of |
Yes, I think so. Maybe we should rename |
Nice, thanks for finding those
Is the split needed? I had thought that the function either
|
Is there a next step for a function which:
I'd be happy to give this a go if we agree on the broad design For names, it's a shame the current |
ref #2650 (comment)
This seems an ugly way of accomplishing the goal; any ideas for a better way of doing this?
And stepping back, do others think a) it's helpful to skip variables in a dataset, and b)
apply_ufunc
should do this?