Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config for closing stale issues #2684

Merged
merged 5 commits into from
Jan 23, 2019
Merged

Config for closing stale issues #2684

merged 5 commits into from
Jan 23, 2019

Conversation

max-sixty
Copy link
Collaborator

Initially set at two years, and max rate of one / hour - we can make more aggressive when we know it's working

@max-sixty max-sixty changed the title stale settings Config for closing stale issues Jan 16, 2019

# Number of days of inactivity before an Issue or Pull Request with the stale label is closed.
# Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale.
daysUntilClose: 7 # start with a large number and reduce over time
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather set to stale after one year, but set daysUntilClose to 4 weeks or so.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree re one year, but let's start with longer and then reduce as we know it's working?

.github/stale.yml Outdated Show resolved Hide resolved
@max-sixty max-sixty merged commit 1e67c23 into pydata:master Jan 23, 2019
@max-sixty max-sixty deleted the stale branch January 23, 2019 02:50
@max-sixty
Copy link
Collaborator Author

This is now active, but rate limited at one per hour and with a two year tolerance. Let me know any thoughts and I'll adjust as necessary

dcherian pushed a commit to dcherian/xarray that referenced this pull request Jan 24, 2019
* master:
  stale requires a label (pydata#2701)
  Update indexing.rst (pydata#2700)
  add line break to message posted (pydata#2698)
  Config for closing stale issues (pydata#2684)
  to_dict without data (pydata#2659)
  Update asv.conf.json (pydata#2693)
  try no rasterio in py36 env (pydata#2691)
  Detailed report for testing.assert_equal and testing.assert_identical (pydata#1507)
  Hotfix for pydata#2662 (pydata#2678)
  Update README.rst (pydata#2682)
  Fix test failures with numpy=1.16 (pydata#2675)
dcherian pushed a commit to yohai/xarray that referenced this pull request Jan 24, 2019
* refactor-plot-utils: (22 commits)
  review comment.
  small rename
  stale requires a label (pydata#2701)
  Update indexing.rst (pydata#2700)
  add line break to message posted (pydata#2698)
  Config for closing stale issues (pydata#2684)
  to_dict without data (pydata#2659)
  Update asv.conf.json (pydata#2693)
  try no rasterio in py36 env (pydata#2691)
  Detailed report for testing.assert_equal and testing.assert_identical (pydata#1507)
  Hotfix for pydata#2662 (pydata#2678)
  Update README.rst (pydata#2682)
  Fix test failures with numpy=1.16 (pydata#2675)
  lint
  Back to map_dataarray_line
  Refactor out cmap_params, cbar_kwargs processing
  Refactor out colorbar making to plot.utils._add_colorbar
  flake8
  facetgrid refactor
  Refactor out utility functions.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants