-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rolling operation with dask and bottleneck #2942
Conversation
@fujiisoup, thanks for looking into this! Unfortunately these tests still seem to still be failing on Travis. |
EDIT: moved to separate PR diff --git a/.travis.yml b/.travis.yml
index 913c5e1c..8249b134 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -19,12 +19,12 @@ matrix:
- env: CONDA_ENV=py36-pandas-dev
- env: CONDA_ENV=py36-rasterio
- env: CONDA_ENV=py36-zarr-dev
+ - env: CONDA_ENV=py36-dask-dev
- env: CONDA_ENV=docs
- env: CONDA_ENV=lint
- env: CONDA_ENV=py36-hypothesis
allow_failures:
- - env: CONDA_ENV=py36-dask-dev
- env:
- CONDA_ENV=py36
- EXTRA_FLAGS="--run-flaky --run-network-tests" |
Hey just wanted to chime in and say it appears that commit fujiisoup@098daf3 is still losing chunking for me as far as I can tell when running it with dask distributed / dask jobqueue. I can do some extended testing & look further into this if people have some suggestions for how to go about it. |
I did a little more looking into this, and I unfortunately I think the necessary fix is a little more involved. For now, I think we should disable |
Hi. Sorry for my slow responce... lf I understood correctly, it happens with dask and bottleneck. |
@fujiisoup yes, indeed, that's a much better temporary fix! See #3040. |
This is subsumed by #3040 |
whats-new.rst
for all changes andapi.rst
for new APIFix for #2940
It looks that there was a bug in the previous logic, but I am not sure why it was working...