Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename combine functions #3043

Merged
merged 5 commits into from
Jun 26, 2019
Merged

Rename combine functions #3043

merged 5 commits into from
Jun 26, 2019

Conversation

TomNicholas
Copy link
Member

Finishes #2616 by renaming
combine_manual -> combine_nested,
combine_auto -> combine_by_coords,
and renaming the arguments to open_mfdataset:
combine='manual' -> combine='nested'
combine='auto' -> combine='by_coords'

[x] code changes
[x] docs changes
[x] what's new updated

@pep8speaks
Copy link

pep8speaks commented Jun 25, 2019

Hello @TomNicholas! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-26 09:12:59 UTC

@shoyer shoyer merged commit 17d18ce into pydata:master Jun 26, 2019
@shoyer
Copy link
Member

shoyer commented Jun 26, 2019

Thanks @TomNicholas, these new combine methods are long awaited!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants