adding stack_all #3115

vrx- · 2019-07-13T21:23:07Z

I'm working on issue #1029. Will try to add a test today. Suggestions welcome

* switching out examples to use nbsphinx * added jupyter_client to doc env * added ipykernel to doc env

* switching out examples to use nbsphinx * added jupyter_client to doc env * moved gallery to notebook

codecov · 2019-07-13T21:33:31Z

Codecov Report

Merging #3115 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3115      +/-   ##
==========================================
- Coverage   95.99%   95.97%   -0.02%     
==========================================
  Files          63       63              
  Lines       12796    12808      +12     
==========================================
+ Hits        12283    12292       +9     
- Misses        513      516       +3

pep8speaks · 2019-07-13T22:18:54Z

Hello @vrx-! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file xarray/core/variable.py:

Line 1304:9: F841 local variable 'result' is assigned to but never used

Comment last updated at 2019-07-17 01:40:06 UTC

dcherian

Thanks @vrx- . I've added some comments.

EDIT: You should add a line under "New functions" in whats-new.rst and give yourself credit.

xarray/core/dataarray.py

dcherian · 2019-07-16T15:40:41Z

xarray/core/dataset.py

+
+        Parameters
+        ----------
+        name : Name of the new dimension. Optional.


Same suggestion as above.

dcherian · 2019-07-16T15:40:57Z

xarray/core/dataset.py

+          * x        (x) |S1 'a' 'b'
+          * y        (y) int64 0 1 2
+        >>> stacked = arr.stack_all()
+        >>> stacked.indexes['z']


dcherian · 2019-07-16T15:41:25Z

xarray/core/dataset.py

+        DataArray.stack
+        DataArray.unstack
+        """
+        result = self


Do we need self.copy()?

xarray/tests/test_variable.py

dcherian · 2019-07-16T15:44:58Z

xarray/tests/test_variable.py

@@ -1341,6 +1341,13 @@ def test_stack(self):
        expected = Variable(('X', 'Y'), v.data, v.attrs)
        assert_identical(actual, expected)

+    def test_stack_all(self):


Let's add similar tests to test_dataarray.py and test_dataset.py

max-sixty

Looks good! Thanks @vrx. I echo @dcherian 's suggestions, and added one tiny change

xarray/core/variable.py

shoyer · 2019-07-16T17:48:17Z

xarray/core/variable.py

@@ -1280,6 +1280,30 @@ def stack(self, dimensions=None, **dimensions_kwargs):
            result = result._stack_once(dims, new_dim)
        return result

+    def stack_all(self, name='stacked'):


I'm not sure we need the xarray.Variable method.

Variable is a lower-level API, mostly for internal use inside xarray to implement functionality for DataArray and Dataset. If we aren't using a Variable method as part of the implementation for Dataset/DataArray, then that is a good clue that it may not be necessary.

Co-Authored-By: Deepak Cherian <dcherian@users.noreply.github.com>

Co-Authored-By: Stephan Hoyer <shoyer@gmail.com>

Co-Authored-By: Deepak Cherian <dcherian@users.noreply.github.com>

dcherian · 2019-08-27T16:00:28Z

Hi @vrx- do you have time to pick this up again?

DancingQuanta · 2019-08-30T15:02:45Z

Would it be possible to add exclude_dims? I have a use case where I wanted to apply a function (for example fitting) along a dimension. I programmatically create a list of dimensions to stack to create 2D dataset. Then I loop over the stacked dimension and apply the function to last dimension.

mathause · 2020-03-25T08:44:01Z

#3826 enables da.stack(stacked=[...]) to stack all dimensions.

Can this also be closed?

max-sixty · 2020-03-25T14:16:06Z

#3826 enables da.stack(stacked=[...]) to stack all dimensions.

Can this also be closed?

I think so.

But @vrx- you made a great start here, and we'd love you to become a contributor in the future!

rabernat and others added 3 commits July 12, 2019 23:52

Switch doc examples to use nbsphinx (#3105)

903495e

* switching out examples to use nbsphinx * added jupyter_client to doc env * added ipykernel to doc env

Replace sphinx_gallery with notebook (#3106)

92cd3c4

* switching out examples to use nbsphinx * added jupyter_client to doc env * moved gallery to notebook

added stack_all()

d5e86fd

added test for stack_all()

6e28409

fixed PEP 8 issue

db8969b

dcherian requested changes Jul 16, 2019

View reviewed changes

max-sixty reviewed Jul 16, 2019

View reviewed changes

xarray/core/variable.py Outdated Show resolved Hide resolved

shoyer reviewed Jul 16, 2019

View reviewed changes

vrx- and others added 3 commits July 16, 2019 14:12

Update xarray/core/dataarray.py

9f42e4d

Co-Authored-By: Deepak Cherian <dcherian@users.noreply.github.com>

Update xarray/core/variable.py

5429719

Co-Authored-By: Stephan Hoyer <shoyer@gmail.com>

Update xarray/tests/test_variable.py

af08ed2

Co-Authored-By: Deepak Cherian <dcherian@users.noreply.github.com>

max-sixty closed this Mar 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding stack_all #3115

adding stack_all #3115

vrx- commented Jul 13, 2019

codecov bot commented Jul 13, 2019 •

edited

Loading

pep8speaks commented Jul 13, 2019 •

edited

Loading

dcherian left a comment •

edited

Loading

dcherian Jul 16, 2019

dcherian Jul 16, 2019

dcherian Jul 16, 2019

dcherian Jul 16, 2019

max-sixty left a comment

shoyer Jul 16, 2019

dcherian commented Aug 27, 2019

DancingQuanta commented Aug 30, 2019

mathause commented Mar 25, 2020

max-sixty commented Mar 25, 2020

adding stack_all #3115

adding stack_all #3115

Conversation

vrx- commented Jul 13, 2019

codecov bot commented Jul 13, 2019 • edited Loading

Codecov Report

pep8speaks commented Jul 13, 2019 • edited Loading

Comment last updated at 2019-07-17 01:40:06 UTC

dcherian left a comment • edited Loading

Choose a reason for hiding this comment

dcherian Jul 16, 2019

Choose a reason for hiding this comment

dcherian Jul 16, 2019

Choose a reason for hiding this comment

dcherian Jul 16, 2019

Choose a reason for hiding this comment

dcherian Jul 16, 2019

Choose a reason for hiding this comment

max-sixty left a comment

Choose a reason for hiding this comment

shoyer Jul 16, 2019

Choose a reason for hiding this comment

dcherian commented Aug 27, 2019

DancingQuanta commented Aug 30, 2019

mathause commented Mar 25, 2020

max-sixty commented Mar 25, 2020

codecov bot commented Jul 13, 2019 •

edited

Loading

pep8speaks commented Jul 13, 2019 •

edited

Loading

dcherian left a comment •

edited

Loading