Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match mypy version between CI and pre-commit hook #3203

Merged
merged 1 commit into from
Aug 11, 2019

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Aug 11, 2019

Pre-commit hook is currently failing because of an issue detected by mypy 0.720 but not by mypy 0.650

Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crusaderky

@crusaderky crusaderky merged commit b0df4d9 into pydata:master Aug 11, 2019
@crusaderky crusaderky deleted the mypy_version branch August 12, 2019 21:03
dcherian added a commit to dcherian/xarray that referenced this pull request Aug 14, 2019
* upstream/master:
  chunk sparse arrays (pydata#3202)
  Annotations for .data_vars() and .coords() (pydata#3207)
  Remove duck_array_ops.as_like_arrays() (pydata#3204)
  Match mypy version between CI and pre-commit hook (pydata#3203)
  BUG fix +test .sel method gives error with float32 values (pydata#3153)
  fix precommit file (pydata#3201)
  Enforce mypy compliance in CI (pydata#3197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants