Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparse fixes for reindex #3255

Merged
merged 15 commits into from
Aug 27, 2019
Merged

Sparse fixes for reindex #3255

merged 15 commits into from
Aug 27, 2019

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Aug 23, 2019 •
edited
Loading

  • Tests added
  • Passes black . && mypy . && flake8
  • Fully documented, including whats-new.rst for all changes and api.rst for new API

shoyer
shoyer reviewed Aug 23, 2019
View reviewed changes
xarray/core/variable.py Outdated Show resolved Hide resolved
xarray/core/variable.py Show resolved Hide resolved
shoyer
shoyer reviewed Aug 23, 2019
View reviewed changes
xarray/core/variable.py Outdated Show resolved Hide resolved
@pep8speaks
Copy link

pep8speaks commented Aug 23, 2019 •
edited
Loading

Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-08-26 23:34:35 UTC

@dcherian dcherian changed the title [WIP] Sparse fixes for reindex/align Sparse fixes for reindex/align Aug 23, 2019
shoyer
shoyer reviewed Aug 24, 2019
View reviewed changes
xarray/core/indexing.py Outdated Show resolved Hide resolved
xarray/core/indexing.py Outdated Show resolved Hide resolved
@dcherian dcherian changed the title Sparse fixes for reindex/align Sparse fixes for reindex Aug 25, 2019
@dcherian
Copy link
Contributor Author

Test fails because we need the git master version of sparse. I opened an issue asking about a release there (pydata/sparse#279)

@dcherian dcherian mentioned this pull request Aug 26, 2019
Closed
@dcherian
Remove some xfail marks.
a088f06
@dcherian
whats-new
5722517
@dcherian
Merge remote-tracking branch 'upstream/master' into sparse-fixes
e114cad 
* upstream/master:
  Initialize empty or full DataArray (pydata#3159)
  Raise on inplace=True (pydata#3260)
  added support for rasterio geotiff tags (pydata#3249)
  Remove sel_points (pydata#3261)
  Fix sparse ops that were calling bottleneck (pydata#3254)
  New feature of filter_by_attrs added (pydata#3259)
  Update filter_by_attrs to use 'variables' instead of 'data_vars' (pydata#3247)
@dcherian dcherian merged commit 851f763 into pydata:master Aug 27, 2019
@dcherian dcherian deleted the sparse-fixes branch August 27, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcherian @pep8speaks @shoyer