Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore h5py 2.10.0 warnings and fix invalid_netcdf warning test. #3301

Merged
merged 6 commits into from
Sep 13, 2019
Merged

ignore h5py 2.10.0 warnings and fix invalid_netcdf warning test. #3301

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
49ee573
ignore h5py 2.10.0 warnings and fix invalid_netcdf warning test.
dcherian Sep 11, 2019
ce4596d
Better fix.
dcherian Sep 12, 2019
e82decc
fix fix.
dcherian Sep 12, 2019
c2c10da
remove comment.
dcherian Sep 12, 2019
14ae0b1
Add docs.
dcherian Sep 12, 2019
fd31618
Revert "Add docs."
dcherian Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions xarray/tests/test_backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2163,6 +2163,7 @@ def test_encoding_unlimited_dims(self):

@requires_h5netcdf
@requires_netCDF4
@pytest.mark.filterwarnings("ignore:use make_scale(name) instead")
class TestH5NetCDFData(NetCDF4Base):
engine = "h5netcdf"

Expand All @@ -2173,16 +2174,25 @@ def create_store(self):

@pytest.mark.filterwarnings("ignore:complex dtypes are supported by h5py")
@pytest.mark.parametrize(
"invalid_netcdf, warns, num_warns",
"invalid_netcdf, warntype, num_warns",
[(None, FutureWarning, 1), (False, FutureWarning, 1), (True, None, 0)],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could just remove the assert len(record) == num_warns line below? I think pytest already verifies that we get a warning with pytest.warns.

We can use the match argument if we want to keep it more specific: https://docs.pytest.org/en/latest/warnings.html#warns

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the complication is testing that the warning is not raised when invalid_netcdf=True. I've changed it to count the number of warnings with the specified warning type and message so that it's more robust.

)
def test_complex(self, invalid_netcdf, warns, num_warns):
def test_complex(self, invalid_netcdf, warntype, num_warns):
expected = Dataset({"x": ("y", np.ones(5) + 1j * np.ones(5))})
save_kwargs = {"invalid_netcdf": invalid_netcdf}
with pytest.warns(warns) as record:
with pytest.warns(warntype) as record:
with self.roundtrip(expected, save_kwargs=save_kwargs) as actual:
assert_equal(expected, actual)
assert len(record) == num_warns

recorded_num_warns = 0
if warntype:
for warning in record:
if issubclass(warning.category, warntype) and (
"complex dtypes" in str(warning.message)
):
recorded_num_warns += 1

assert recorded_num_warns == num_warns

def test_cross_engine_read_write_netcdf4(self):
# Drop dim3, because its labels include strings. These appear to be
Expand Down Expand Up @@ -2451,6 +2461,7 @@ def skip_if_not_engine(engine):


@requires_dask
@pytest.mark.filterwarnings("ignore:use make_scale(name) instead")
def test_open_mfdataset_manyfiles(
readengine, nfiles, parallel, chunks, file_cache_maxsize
):
Expand Down