Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict pytest to 'unit' tests (i.e. not hypothesis) #3471

Closed
wants to merge 1 commit into from

Conversation

max-sixty
Copy link
Collaborator

Currently Azure is running hypothesis tests in any test job that has hypothesis installed (found in #3285). This isn't required, since we have a separate job for hypothesis, and slows down the normal tests.

We can either exclude it in the test job or in the tests that pytest runs as specified in setup.cfg

I think adjusting pytest's test paths in setup.cfg is a more logical place: pytest is responsible for running normal / unit tests in xarray/tests, and hypothesis can run the tests in properties

@crusaderky
Copy link
Contributor

That was a conscious decision based on the observation that the whole lot of the hypothesis tests was taking something like 3 seconds. Has this changed now?

@max-sixty
Copy link
Collaborator Author

Ah. Am I thinking there's a separate hypothesis job when actually there isn't?

@crusaderky
Copy link
Contributor

@max-sixty there used to. I took it away.

@crusaderky crusaderky closed this Oct 31, 2019
@crusaderky
Copy link
Contributor

End-to-end runtime for properties, as of the git tip, is 1.65 seconds

@max-sixty max-sixty deleted the test-paths branch October 31, 2019 14:28
@max-sixty
Copy link
Collaborator Author

Great. Thanks for being ahead of me on some of these recent issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants