Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whats-new for 0.15 #3723

Merged
merged 17 commits into from
Jan 28, 2020
Merged

Fix whats-new for 0.15 #3723

merged 17 commits into from
Jan 28, 2020

Conversation

dcherian
Copy link
Contributor

whats-new fixes.

@dcherian dcherian requested a review from keewis January 26, 2020 17:11
@dcherian
Copy link
Contributor Author

dcherian commented Jan 26, 2020 •
edited
Loading

We should

  • mention that the examples are now binderized
  • link from whats-new descriptions of new examples to the example notebooks

keewis
keewis reviewed Jan 26, 2020
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes a few nitpicky warnings

doc/whats-new.rst Outdated Show resolved Hide resolved
doc/whats-new.rst Outdated Show resolved Hide resolved
@keewis
Copy link
Collaborator

keewis commented Jan 26, 2020

you should be able to link using the path relative to doc/ without the file extension, e.g.

:doc:`examples/ERA5-GRIB-example`

@keewis
Copy link
Collaborator

keewis commented Jan 26, 2020

also, the docstring of plot.step produces warnings. Do you want to fix it here or should I open a new PR for that?

@dcherian
Copy link
Contributor Author

You should be able to push to this branch

dcherian and others added 4 commits January 26, 2020 21:27
@dcherian @keewis
Update doc/whats-new.rst
b2d4a2c 
Co-Authored-By: keewis <keewis@users.noreply.github.com>
@dcherian @keewis
Update doc/whats-new.rst
7650a2c 
Co-Authored-By: keewis <keewis@users.noreply.github.com>
@dcherian
more fixes.
f3a068b
@keewis
fix the docstring of step
ab71c29
@keewis
Copy link
Collaborator

keewis commented Jan 26, 2020

done

@dcherian
Copy link
Contributor Author

Thanks @keewis. This should be good to go. I converted the weather-data example to a jupyter notebook too.

@keewis
Copy link
Collaborator

keewis commented Jan 27, 2020

looks good to me, but we have broken references to toy weather data and fill with climatology, which were labels in the rst version of the example. Should we update those or replace them with the captions they referred to, Toy weather data and Fill missing values with climatology?

@keewis
Copy link
Collaborator

keewis commented Jan 28, 2020 •
edited
Loading

you can also refer to the captions in a notebook:

:ref:`/examples/weather-data.ipynb#Toy-weather-data`
:ref:`/examples/weather-data.ipynb#Fill-missing-values-with-climatology`

@dcherian
Copy link
Contributor Author

hmmm I couldn't get that to work. Since it's just some old whats-new entries, I think we should merge and release.

dcherian and others added 4 commits January 28, 2020 14:45
@keewis
Copy link
Collaborator

keewis commented Jan 28, 2020

should be ready to merge now

@dcherian dcherian merged commit d63888c into pydata:master Jan 28, 2020
@dcherian
Copy link
Contributor Author

woot! thanks!

@dcherian dcherian deleted the 0.15-whats-new branch January 28, 2020 23:08
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 31, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into groupby-plot
c83c617 
* upstream/master:
  Python 3.8 CI (pydata#3727)
  PKG: Explicitly add setuptools dependency (pydata#3628)
  update whats-new
  Typo in Universal Functions section (pydata#3663)
  Release v0.15.0
  fix setup.cfg
  Documentation fixes (pydata#3732)
  Remove extra && in PR template (pydata#3730)
  Remove garbage text inserted in DASK_LICENSE (pydata#3729)
  Avoid unsafe use of pip (pydata#3726)
  remove PR pre-black instructions (pydata#3707)
  Fix whats-new for 0.15 (pydata#3723)
  Add isort to CI (pydata#3721)
  setuptools-scm (3) (pydata#3724)
  Fix Sphinx links on contributing doc page (pydata#3710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherian @keewis