Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for better error message about in-place operation #3976

Merged
merged 4 commits into from
Jun 24, 2020
Merged

Proposal for better error message about in-place operation #3976

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b2b0dc
Improve error message: automatic alignment during in-place operation.
mancellin Apr 15, 2020
2f30c0f
Sorted imports.
mancellin Apr 15, 2020
fd96e0f
Fix tests.
mancellin Apr 15, 2020
a82b023
Add suggestions from S. Hoyer.
mancellin Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions xarray/core/dataarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
from .formatting import format_item
from .indexes import Indexes, default_indexes, propagate_indexes
from .indexing import is_fancy_indexer
from .merge import PANDAS_TYPES, _extract_indexes_from_coords
from .merge import PANDAS_TYPES, MergeError, _extract_indexes_from_coords
from .options import OPTIONS
from .utils import Default, ReprObject, _check_inplace, _default, either_dict_or_kwargs
from .variable import (
Expand Down Expand Up @@ -2663,8 +2663,15 @@ def func(self, other):
# don't support automatic alignment with in-place arithmetic.
other_coords = getattr(other, "coords", None)
other_variable = getattr(other, "variable", other)
with self.coords._merge_inplace(other_coords):
f(self.variable, other_variable)
try:
with self.coords._merge_inplace(other_coords):
f(self.variable, other_variable)
except MergeError:
raise ValueError(
mancellin marked this conversation as resolved.
Show resolved Hide resolved
"Automatic alignment is not supported for in-place operations.\n"
"Consider aligning the indices manually or using a not-in-place operation.\n"
"See https://github.com/pydata/xarray/issues/3910 for more explanations."
)
mancellin marked this conversation as resolved.
Show resolved Hide resolved
return self

return func
Expand Down
4 changes: 2 additions & 2 deletions xarray/tests/test_dataarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1921,9 +1921,9 @@ def test_inplace_math_basics(self):
def test_inplace_math_automatic_alignment(self):
a = DataArray(range(5), [("x", range(5))])
b = DataArray(range(1, 6), [("x", range(1, 6))])
with pytest.raises(xr.MergeError):
with pytest.raises(ValueError):
mancellin marked this conversation as resolved.
Show resolved Hide resolved
a += b
with pytest.raises(xr.MergeError):
with pytest.raises(ValueError):
b += a

def test_math_name(self):
Expand Down