Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfail failing upstream plotting tests #4271

Merged
merged 3 commits into from
Jul 25, 2020
Merged

xfail failing upstream plotting tests #4271

merged 3 commits into from
Jul 25, 2020

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Jul 25, 2020 •
edited
Loading

  • Passes isort . && black . && mypy . && flake8

Master has been failing for a while now recently started failing — while xfailing these isn't ideal, I think it's probably better than the having master continue to fail — any thoughts?

If there's some middle ground — like the "allowed failures" we had in Travis a few years ago, that could be ideal.

@max-sixty max-sixty mentioned this pull request Jul 25, 2020
Closed
spencerkclark
spencerkclark approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @max-sixty; I agree.

@max-sixty max-sixty merged commit 83987b7 into pydata:master Jul 25, 2020
@max-sixty max-sixty deleted the xfail-upstream branch July 25, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerkclark spencerkclark spencerkclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-sixty @spencerkclark