-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update signature open_dataset for API v2 #4547
Merged
Merged
Changes from 48 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
f961606
add in api.open_dataset dispatching to stub apiv2
aurghs fb166fa
remove in apiv2 check for input AbstractDataStore
aurghs 0221eec
bugfix typo
aurghs 36a02c7
add kwarg engines in _get_backend_cls needed by apiv2
aurghs cfb8cb8
add alpha support for h5netcdf
aurghs 4256bc8
style: clean not used code, modify some variable/function name
aurghs 1bc7391
Add ENGINES entry for cfgrib.
748fe5a
Define function open_backend_dataset_cfgrib() to be used in apiv2.py.
fb368fe
Apply black to check formatting.
80e111c
Apply black to check formatting.
e15ca6b
add dummy zarr apiv2 backend
aurghs 025cc87
Merge branch 'master' into backend-read-refactor
aurghs 4b19399
align apiv2.open_dataset to api.open_dataset
aurghs 572595f
remove unused extra_coords in open_backend_dataset_*
aurghs d6e632e
Merge remote-tracking branch 'origin/cfgrib_refactor' into backend-re…
aurghs 74aba14
remove extra_coords in open_backend_dataset_cfgrib
aurghs d6280ec
transform zarr maybe_chunk and get_chunks in classmethod
aurghs c0e0f34
make alpha zarr apiv2 working
aurghs 6431101
refactor apiv2.open_dataset:
aurghs 50d1ebe
move dataset_from_backend_dataset out of apiv2.open_dataset
aurghs 383d323
remove blank lines
aurghs 457a09c
remove blank lines
aurghs 2803fe3
style
aurghs 08db0bd
Re-write error messages
alexamici 1f11845
Fix code style
alexamici 93303b1
Fix code style
alexamici bc2fe00
remove unused import
aurghs d694146
replace warning with ValueError for not supported kwargs in backends
aurghs 56f4d3f
change zarr.ZarStore.get_chunks into a static method
aurghs df23b18
group `backend_kwargs` and `kwargs` in `extra_tokes` argument in apiv…
aurghs a04e6ac
remove in open_backend_dayaset_${engine} signature kwarags and the re…
aurghs de29a4c
black
aurghs be8c23b
Change signature of open_dataset function in apiv2 to include explici…
feb486c
Set an alias for chunks='auto'.
8f6af46
Allign empty rows with previous version.
c9088d3
reverse changes in chunks management
aurghs fe8099c
move check on decoders from backends to open_dataset (apiv2)
aurghs fed8b3e
update documentation
aurghs 6fec3ea
Change signature of open_dataset function in apiv2 to include explici…
231895e
Set an alias for chunks='auto'.
b88b567
Allign empty rows with previous version.
be51bc7
reverse changes in chunks management
aurghs 5aa533d
move check on decoders from backends to open_dataset (apiv2)
aurghs 7e75f1c
update documentation
aurghs 2047d46
Merge branch 'change-signature-open_dataset' of github.com:bopen/xarr…
aurghs 3057abb
change defaut value for decode_cf in open_dataset. The function bahav…
aurghs 842fc29
Review docstring of open_dataset function.
ff1181c
bugfix typo
aurghs bdcf0fe
- add check on backends signatures
aurghs 61be8a8
- black isort
aurghs c0b290a
- add type declaration in plugins.py
aurghs c217031
Fix the type hint for ENGINES
alexamici 8530ff0
Drop special case and simplify resolve_decoders_kwargs
alexamici 73328ac
isort
alexamici File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this special case
d != "use_cftime"
? Does it break any tests if we simply remove it?(My guess is that the existing code may not bother to set
use_cftime = False
, but only because the value ofuse_cftime
is ignored ifdecode_times = False
.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have forgotten to check it. You are right, we can remove it.