Added encoding options for netCDF4 variables #50
Conversation
| @@ -151,7 +151,23 @@ def convert_variable(var): | |||
| data = np.asscalar(var[...]) | |||
| attributes = OrderedDict((k, var.getncattr(k)) | |||
| for k in var.ncattrs()) | |||
| return xarray.XArray(dimensions, data, attributes, | |||
| # netCDF4 specific encoding; save _FillValue for later | |||
There was a problem hiding this comment.
Is there a way to throw warnings across the board for those encoding variables found but not expected by the given data store?
There was a problem hiding this comment.
We could do that, but are we sure that's a good thing? I can see that popping up a lot of warnings when serializing a dataset from netCDF4 to netCDF3, for example...
There was a problem hiding this comment.
Is that unreasonable? Maybe you're right. If at some point it's
worthwhile to have different logging levels as part of the package, this is
something that could be brought back in.
On Wed, Mar 5, 2014 at 4:36 PM, Stephan Hoyer notifications@github.comwrote:
In src/xray/backends.py:
@@ -151,7 +151,23 @@ def convert_variable(var):
data = np.asscalar(var[...])
attributes = OrderedDict((k, var.getncattr(k))
for k in var.ncattrs())
return xarray.XArray(dimensions, data, attributes,# netCDF4 specific encoding; save _FillValue for laterWe could do that, but are we sure that's a good thing? I can see that
popping up a lot of warnings when serializing a dataset from netCDF4 to
netCDF3, for example...Reply to this email directly or view it on GitHubhttps://github.com/akleeman/xray/pull/50/files#r10326856
.
Added encoding options for netCDF4 variables
* added assert functions * pseudocode for printing differences between trees - need tests * equals->identical fix * refactored to use same diff function for asserts and to check isomorphism internally * added tests of tree diff formatting * added option to check trees from the root * fix bugs with assert functions
This now allows for variable specific compression.