Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add polyval to polyfit see also #5020

Merged
merged 4 commits into from
Mar 10, 2021
Merged

add polyval to polyfit see also #5020

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50d57d9
add polyval to polyfit see also
Mar 10, 2021
5f93b12
whatsnew
Mar 10, 2021
a65a221
link polyval to docs
Mar 10, 2021
13df82f
link polyval to docs
Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ Documentation
~~~~~~~~~~~~~
- New section on :ref:`add_a_backend` in the "Internals" chapter aimed to backend developers
(:issue:`4803`, :pull:`4810`). By `Aureliana Barghini <https://github.com/aurghs>`_.
- Add :py:meth:`Dataset.polyfit` and :py:meth:`DataArray.polyfit` under "See also" in
the docstrings of :py:meth:`Dataset.polyfit` and :py:meth:`DataArray.polyfit`
(:issue:`5016`, :pull:`5020`). By `Aaron Spring <https://github.com/aaronspring>`_.


Internal Changes
Expand Down
2 changes: 2 additions & 0 deletions xarray/core/dataarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3781,6 +3781,8 @@ def polyfit(
See Also
--------
numpy.polyfit
numpy.polyval
xarray.DataArray.polyval
keewis marked this conversation as resolved.
Show resolved Hide resolved
"""
return self._to_temp_dataset().polyfit(
dim, deg, skipna=skipna, rcond=rcond, w=w, full=full, cov=cov
Expand Down
2 changes: 2 additions & 0 deletions xarray/core/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6399,6 +6399,8 @@ def polyfit(
See Also
--------
numpy.polyfit
numpy.polyval
xarray.Dataset.polyval
"""
variables = {}
skipna_da = skipna
Expand Down