Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coarsen: better keep_attrs #5227

Merged
merged 3 commits into from
Apr 29, 2021
Merged

coarsen: better keep_attrs #5227

merged 3 commits into from
Apr 29, 2021
+251 −70

Conversation

mathause
Copy link
Collaborator

As per #3891 (comment) I also changed the default to True.

max-sixty
max-sixty approved these changes Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @mathause !

@TomNicholas TomNicholas merged commit 9ce95a8 into pydata:master Apr 29, 2021
@TomNicholas TomNicholas mentioned this pull request Apr 29, 2021
Closed
13 tasks
@mathause mathause mentioned this pull request May 5, 2021
Closed
@mathause mathause deleted the coarsen_keep_attrs branch October 18, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathause @max-sixty @TomNicholas