-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametrize test for __setitem__ (for dask array) #5243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @andersy005.
We could avoid parametrizing the original array and the index value here — these examples have them all the same, and we don't need to test over multiple values.
As a principle I'd vote to parametrize the minimum amount needed (though no less 😀). At the extreme, we could put everything in some lisp-like data structure and the test just be func(input) == expected
, but that's arguably harder to follow than more imperative code.
Thank you for the feedback, @max-sixty! I removed the redundant parameters... Let me know if there is anything else worth addressing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks a lot @andersy005 !
This should be mergeable once the CI is passing |
The flaky/failing test is due to an unstable OpenDAP server.... |
Thanks @andersy005! |
Follow up PR for #5174
pre-commit run --all-files