Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dataset groupby tests #5506

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Refactor dataset groupby tests #5506

merged 2 commits into from
Jun 22, 2021

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Jun 21, 2021 •
edited
Loading

Just moves the tests out, in preparation for numpy_groupies work

There are a few tests for .assign and .fillna (for e.g.) still present in test_dataset

The DataArray tests are not a simple copy and paste :(

mathause
mathause approved these changes Jun 22, 2021
View reviewed changes
xarray/tests/test_groupby.py Outdated Show resolved Hide resolved
@dcherian @mathause
Update xarray/tests/test_groupby.py
4b7d0cf 
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
max-sixty
max-sixty approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dcherian dcherian merged commit 1f5c633 into pydata:master Jun 22, 2021
@dcherian dcherian deleted the groupby-tests branch June 22, 2021 16:00
@github-actions
Copy link
Contributor

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1f5c633. ± Comparison against base commit 1f5c633.

dcherian added a commit to dcherian/xarray that referenced this pull request Jun 23, 2021
@dcherian
Merge branch 'main' into coarsen_reshape
56d8c36 
* main:
  Improve error message for guess engine (pydata#5455)
  Refactor dataset groupby tests (pydata#5506)
  DOC: zarr note on encoding (pydata#5427)
  Allow plotting categorical data (pydata#5464)
@TomNicholas TomNicholas mentioned this pull request Jul 8, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcherian @max-sixty @mathause