-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added get_options method #5716
Added get_options method #5716
Conversation
The returned dict should be read only, otherwise you can bypass all the validation checks that's done in Line 476 in 56cc077
Not sure if FrozenDict propagates the typing though, once OPTIONS is typed. We probably need to make sure that |
This looks good., thanks @pkopparla Thanks for reviewing @Illviljan . Agree re a test — at least to just test it runs, albeit trivial.
|
Thank you @Illviljan @max-sixty Edit: All unit tests are passing on my local PC but there's one failure in the github checks. |
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pkopparla This is a great improvement!
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pkopparla
I'll merge in a couple of days if there are no more comments
Awesome, thanks @dcherian and all the reviewers! |
pre-commit run --all-files
whats-new.rst
api.rst
Added a
get_options
method undercore/options.py
. At the moment it returns the OPTIONS dictionary as is to keep it very simple, if a formatted print statement with text is desirable I can try to add it.Edit: Some tests are failing, but they are unrelated to my changes. Not sure how to address the errors.