Handle single PathLike objects in open_mfdataset()
#5884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that the errors are not related to the changes. |
TomNicholas
reviewed
Oct 22, 2021
There was a problem hiding this comment.
Yes the test failures look like they are the same as in #5875.
This looks good - could you just add a note to the /doc/whatsnew.rst file?
Closed
dcherian
reviewed
Oct 24, 2021
|
Thanks @pmav99 I see this is your first PR. Welcome to xarray! |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Oct 29, 2021
* main: Add typing_extensions as a required dependency (pydata#5911) pydata#5740 follow up: supress xr.ufunc warnings in tests (pydata#5914) Avoid accessing slow .data in unstack (pydata#5906) Add wradlib to ecosystem in docs (pydata#5915) Use .to_numpy() for quantified facetgrids (pydata#5886) [test-upstream] fix pd skipna=None (pydata#5899) Add var and std to weighted computations (pydata#5870) Check for path-like objects rather than Path type, use os.fspath (pydata#5879) Handle single `PathLike` objects in `open_mfdataset()` (pydata#5884)
snowman2
pushed a commit
to snowman2/xarray
that referenced
this pull request
Feb 9, 2022
* Handle single `PathLike` objects in `open_mfdataset()` Fixes pydata#5881 * Update doc/whats-new.rst Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com> Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open_mfdatasetdoes not handle singlepathlib.Pathobjects but handles singlestrjust fine #5881pre-commit run --all-fileswhats-new.rstapi.rst