Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/to dict encoding #6635

Merged
merged 5 commits into from
May 26, 2022
Merged

Feature/to dict encoding #6635

merged 5 commits into from
May 26, 2022

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented May 24, 2022 •
edited
Loading

This adds an encoding option to Xarray's to_dict methods.

Illviljan
Illviljan reviewed May 24, 2022
View reviewed changes
xarray/core/dataset.py Outdated Show resolved Hide resolved
jhamman and others added 4 commits May 24, 2022 16:41
@jhamman @Illviljan
Update xarray/core/dataset.py
c2c9d6c 
Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
@jhamman @Illviljan
Update xarray/tests/test_dataarray.py
67cd1e0 
Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
type dict in to_dict
4f7c2c5
add whats new
9cee34d
@jhamman jhamman requested a review from andersy005 May 26, 2022 15:29
andersy005
andersy005 approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you @jhamman

@andersy005 andersy005 added the plan to merge Final call for comments label May 26, 2022
@TomNicholas TomNicholas merged commit 0ea1e35 into pydata:main May 26, 2022
@jhamman jhamman deleted the feature/to-dict-encoding branch May 26, 2022 19:50
dcherian added a commit to dcherian/xarray that referenced this pull request Jun 12, 2022
@dcherian
Merge branch 'main' into groupby-refactor-init
1277544 
* main: (95 commits)
  Use `zarr` to validate attrs when writing to zarr (pydata#6636)
  Add pre-commit hook to check CITATION.cff (pydata#6658)
  Fix kwargs used for extrapolation in docs (pydata#6639)
  Fix notebooks' HTML links (pydata#6655)
  Doc index update (pydata#6530)
  CFTime support for polyval (pydata#6624)
  Support dask arrays in datetime_to_numeric (pydata#6556)
  [pre-commit.ci] pre-commit autoupdate (pydata#6654)
  0-padded month. (pydata#6653)
  [test-upstream] import `cleanup` fixture from `distributed` (pydata#6650)
  Allow all interp methods in typing (pydata#6647)
  Typing support for custom backends (pydata#6651)
  Improved DataArray typing (pydata#6637)
  Adjust code comments & types from pydata#6638 (pydata#6642)
  Typing of `str` and `dt` accessors (pydata#6641)
  Feature/to dict encoding (pydata#6635)
  fix {full,zeros,ones}_like overloads (pydata#6630)
  Mypy badge (pydata#6626)
  concatenate docs style (pydata#6621)
  Typing for open_dataset/array/mfdataset and to_netcdf/zarr (pydata#6612)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Illviljan Illviljan Illviljan left review comments

@andersy005 andersy005 andersy005 approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optionally include encoding in Dataset to_dict
4 participants
@jhamman @andersy005 @Illviljan @TomNicholas