Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdyap version dependent client.open_url call #6656

Merged
merged 6 commits into from
Jun 16, 2022
Merged

pdyap version dependent client.open_url call #6656

merged 6 commits into from
Jun 16, 2022

Conversation

observingClouds
Copy link
Contributor

@observingClouds observingClouds commented Jun 1, 2022 •
edited
Loading

@observingClouds
Copy link
Contributor Author

Shall we raise a warning in case verify and/or user_charset are given and the used pydap version is older than 3.0.0? Or is it fine to just ignore those arguments in this case without warning the user?

dcherian
dcherian reviewed Jun 1, 2022
View reviewed changes
xarray/backends/pydap_.py Outdated Show resolved Hide resolved
dcherian
dcherian reviewed Jun 3, 2022
View reviewed changes
xarray/backends/pydap_.py Outdated Show resolved Hide resolved
@dcherian
Copy link
Contributor

dcherian commented Jun 3, 2022

Our tests on min-all-deps are running with pydap 3.2.2 but were passing. Was the test xfailed? If so can we remove it.

@observingClouds
Copy link
Contributor Author

observingClouds commented Jun 3, 2022 •
edited
Loading

Our tests on min-all-deps are running with pydap 3.2.2 but were passing. Was the test xfailed? If so can we remove it.

Actually, the general unit test should fail but the specific tests are skipped. Only when the flag --run-network-tests is provided to pytest the tests run and would have failed in the past.

@observingClouds observingClouds marked this pull request as ready for review June 8, 2022 09:10
@dcherian
Copy link
Contributor

Thanks @observingClouds . We could definitely improve test coverage here if you're up for making some more contributions in the future.

@dcherian dcherian merged commit 9a71990 into pydata:main Jun 16, 2022
@observingClouds observingClouds deleted the fix_6648_pydap-version branch June 17, 2022 09:38
dcherian added a commit to bzah/xarray that referenced this pull request Jun 24, 2022
@dcherian
Merge branch 'main' into fix/dask_indexing
d5e7646 
* main: (129 commits)
  docs on specifying chunks in to_zarr encoding arg (pydata#6542)
  [skip-ci] List count under Aggregation (pydata#6711)
  Add `Dataset.dtypes` property (pydata#6706)
  try to import `UndefinedVariableError` from the new location (pydata#6701)
  DOC: note of how `chunks` can be defined (pydata#6696)
  pdyap version dependent client.open_url call (pydata#6656)
  use `pytest-reportlog` to generate upstream-dev CI failure reports (pydata#6699)
  [pre-commit.ci] pre-commit autoupdate (pydata#6694)
  Bump actions/setup-python from 3 to 4 (pydata#6692)
  Fix Dataset.where with drop=True and mixed dims (pydata#6690)
  pass kwargs through from save_mfdataset to to_netcdf (pydata#6686)
  Docs: indexing.rst finetuning (pydata#6685)
  use micromamba instead of mamba (pydata#6674)
  install the development version of `matplotlib` into the upstream-dev CI (pydata#6675)
  Add whatsnew section for v2022.06.0
  release notes for 2022.06.0rc0
  release notes for the pre-release (pydata#6676)
  more testpypi workflow fixes (pydata#6673)
  thin: add examples (pydata#6663)
  Update multidimensional-coords.ipynb (pydata#6672)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian Awaiting requested review from dcherian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading data with pydap engine fails due to outdated/missing dependency
2 participants
@observingClouds @dcherian