-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DataArrayRolling.__iter__
with center=True
#6744
Conversation
I am now trying to get this to work for Datasets as well. Is there a way to get a boolean, scalar DataArray/set that contains this information? |
Would it be useful to add a function
? But maybe this already works easily and I just don't know about it? |
But maybe that is already too complicated. Anyone has an idea how to get this:
operate only on variables that contain self.dim[0]? |
Btw: this issue #6749 is the reason why it currently does not work for datasets. |
Would you mind moving the first commit to a new PR that we can merge quickly please? It'll be easier to see any new tests you've added then |
I'm fast in adding scope kreep xD |
We could merge this PR after a final review. For a DatasetRolling.iter support we could either open a new issue or just wait until someone requests it :) |
Thanks @headtr1ck |
* main: (313 commits) Update whats-new Release notes for v2022.06.0 (pydata#6815) Drop multi-indexes when assigning to a multi-indexed variable (pydata#6798) Support NumPy array API (experimental) (pydata#6804) Add cumsum to DatasetGroupBy (pydata#6525) Refactor groupby binary ops code. (pydata#6789) Update DataArray.rename + docu (pydata#6665) Switch to T_DataArray and T_Dataset in concat (pydata#6784) Fix typos found by codespell (pydata#6794) Update groupby attrs tests (pydata#6787) Update map_blocks to use chunksizes property. (pydata#6776) Fix `DataArrayRolling.__iter__` with `center=True` (pydata#6744) [test-upstream] Update flox repo URL (pydata#6780) Move _infer_meta_data and _parse_size to utils (pydata#6779) Make the `sel` error more descriptive when `method` is unset (pydata#6774) Move Rolling tests to their own testing module (pydata#6777) [pre-commit.ci] pre-commit autoupdate (pydata#6773) move da and ds fixtures to conftest.py (pydata#6730) Bump EnricoMi/publish-unit-test-result-action from 1 to 2 (pydata#6770) Type shape methods (pydata#6767) ...
whats-new.rst
New functions/methods are listed inapi.rst
I have taken the freedom to move all rolling related tests into their own testing module.
#6730 should then take care of the (by now) copy-pasted
da
andds
fixtures.