Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of repr and deepcopy of recursive arrays #7112

Merged
merged 8 commits into from
Oct 6, 2022
Merged

Support of repr and deepcopy of recursive arrays #7112

merged 8 commits into from
Oct 6, 2022

Conversation

headtr1ck
Copy link
Collaborator

@headtr1ck headtr1ck commented Oct 1, 2022 •
edited
Loading

xarray.testing.assert_identical and probably more do not work yet.

@headtr1ck headtr1ck changed the title Support deepcopy of recursive arrays Support of repr and deepcopy of recursive arrays Oct 1, 2022
@max-sixty
Copy link
Collaborator

Looks excellent!

(there are a few tests commented out, not sure whether that's intentional...)

@headtr1ck
Copy link
Collaborator Author

Looks excellent!

(there are a few tests commented out, not sure whether that's intentional...)

Whoops

@headtr1ck headtr1ck added the plan to merge Final call for comments label Oct 2, 2022
@headtr1ck headtr1ck mentioned this pull request Oct 4, 2022
Closed
4 tasks
@headtr1ck headtr1ck enabled auto-merge (squash) October 6, 2022 21:28
@headtr1ck headtr1ck merged commit 50ea159 into pydata:main Oct 6, 2022
@headtr1ck headtr1ck deleted the deepcopy branch October 7, 2022 11:10
@headtr1ck headtr1ck mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New deep copy behavior in 2022.9.0 causes maximum recursion error
2 participants
@headtr1ck @max-sixty