Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debugging slow assert statement #7221

Merged
merged 8 commits into from
Oct 28, 2022
Merged

Remove debugging slow assert statement #7221

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4b8301f
Remove debugging slow assert statement
hmaarrfk Oct 26, 2022
a948b95
Add a benchmark
hmaarrfk Oct 26, 2022
ec972e0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 26, 2022
119a546
Update asv_bench/benchmarks/dataset_creation.py
Illviljan Oct 26, 2022
040ac3b
Rework the benchmark
hmaarrfk Oct 26, 2022
3f314f0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 26, 2022
02b4256
Merge branch 'main' into patch-1
dcherian Oct 27, 2022
1a58759
Delete dataset_creation.py
dcherian Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions asv_bench/benchmarks/dataset_creation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ def setup(self):
# so lets force modules to get instantiated here, instead of
# in the benchmark
dummy_dataset = xr.Dataset()
dummy_dataset['a'] = 1
dummy_dataset['b'] = 1
dummy_dataset["a"] = 1
dummy_dataset["b"] = 1
dcherian marked this conversation as resolved.
Show resolved Hide resolved

self.dataset = xr.Dataset()

Expand Down