Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #7360

Merged
merged 2 commits into from
Dec 18, 2022
Merged

[pre-commit.ci] pre-commit autoupdate #7360

merged 2 commits into from
Dec 18, 2022

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Dec 5, 2022 •
edited
Loading

@github-actions github-actions bot added the needs triage Issue that has not been reviewed by xarray team member label Dec 5, 2022
@jhamman
Copy link
Member

jhamman commented Dec 6, 2022

This is failing with the following error:

/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/distributed/scheduler.py:120: error: disable_error_code: Invalid error code(s): annotation-unchecked  [misc]

Possibly related to #7319

@Illviljan
Copy link
Contributor

The mypy errors should be fixed soon I think: dask/distributed#7378

jrbourbeau
jrbourbeau reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up, dask/distributed#7379 has been merged

@jrbourbeau
Copy link
Contributor

Looks like the latest distributed release is being used in the mypy CI build. dask/distributed#7379 will be included in the next release which is currently slated for next Friday, December 16.

Not sure if it makes sense to temporarily use the main branch of distributed in CI until then, or use some other mypy-related workaround

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
b112fb0 
updates:
- [github.com/asottile/pyupgrade: v3.2.2 → v3.3.1](asottile/pyupgrade@v3.2.2...v3.3.1)
- [github.com/psf/black: 22.10.0 → 22.12.0](psf/black@22.10.0...22.12.0)
@Illviljan Illviljan merged commit bbe63ab into main Dec 18, 2022
@Illviljan Illviljan deleted the pre-commit-ci-update-config branch December 18, 2022 11:06
jrbourbeau
jrbourbeau reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Illviljan!

dcherian added a commit to dcherian/xarray that referenced this pull request Jan 18, 2023
@dcherian
Merge branch 'main' into kvikio
426519f 
* main: (41 commits)
  v2023.01.0 whats-new (pydata#7440)
  explain keep_attrs in docstring of apply_ufunc (pydata#7445)
  Add sentence to open_dataset docstring (pydata#7438)
  pin scipy version in doc environment (pydata#7436)
  Improve performance for backend datetime handling (pydata#7374)
  fix typo (pydata#7433)
  Add lazy backend ASV test (pydata#7426)
  Pull Request Labeler - Workaround sync-labels bug (pydata#7431)
  see also : groupby in resample doc and vice-versa (pydata#7425)
  Some alignment optimizations (pydata#7382)
  Make `broadcast` and `concat` work with the Array API (pydata#7387)
  remove `numbagg` and `numba` from the upstream-dev CI (pydata#7416)
  [pre-commit.ci] pre-commit autoupdate (pydata#7402)
  Preserve original dtype when accessing MultiIndex levels (pydata#7393)
  [pre-commit.ci] pre-commit autoupdate (pydata#7389)
  [pre-commit.ci] pre-commit autoupdate (pydata#7360)
  COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement (pydata#7361)
  Avoid loading entire dataset by getting the nbytes in an array (pydata#7356)
  `keep_attrs` for pad (pydata#7267)
  Bump pypa/gh-action-pypi-publish from 1.5.1 to 1.6.4 (pydata#7375)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrbourbeau jrbourbeau jrbourbeau left review comments

Assignees
No one assigned
Labels
needs triage Issue that has not been reviewed by xarray team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhamman @Illviljan @jrbourbeau