Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose "Coordinates" as part of Xarray's public API #7368

Merged
merged 76 commits into from
Jul 21, 2023

Commits on Oct 25, 2022

  1. Configuration menu
    Copy the full SHA
    41f4fd8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4baa8af View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Indexes constructor updates

    - easily create an empty Indexes collection
    - check consistency between indexes and variables
    benbovy committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    dbc058a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    16a9983 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c076d5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    70e7a5d View commit details
    Browse the repository at this point in the history
  5. fix Dataset dimensions

    TODO: check indexes shapes / dims for DataArray
    benbovy committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    00e1766 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3bf92cd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c9b6363 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. docstrings tweaks

    benbovy committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    82dc5cc View commit details
    Browse the repository at this point in the history
  2. more Indexes safety

    Since its constructor can now be used publicly.
    
    Copy input mappings and check the type of input indexes.
    benbovy committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    a58c9d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9beeea7 View commit details
    Browse the repository at this point in the history
  4. add .assign_indexes() method

    benbovy committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c6e94b4 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Configuration menu
    Copy the full SHA
    ddd505e View commit details
    Browse the repository at this point in the history
  2. add IndexedCoordinates subclass

    + add `IndexedCoordinates.from_pandas_multiindex` helper.
    benbovy committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f97adb5 View commit details
    Browse the repository at this point in the history
  3. rollback/update Dataset and DataArray constructors

    Drop the `indexes` argument or keep it as private API.
    
    When a `Coordinates` object is passed as `coords` argument, extract both
    coordinate variables and indexes and add them to the new Dataset or
    DataArray.
    benbovy committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    45709ef View commit details
    Browse the repository at this point in the history
  4. update docstrings

    benbovy committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    4c559f1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1192948 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Configuration menu
    Copy the full SHA
    a877a74 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Configuration menu
    Copy the full SHA
    9d6d2ae View commit details
    Browse the repository at this point in the history
  2. update api docs

    benbovy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    3ee26ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd02eca View commit details
    Browse the repository at this point in the history
  4. docstrings updates

    benbovy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    0ee8f95 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fc6c948 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0572b96 View commit details
    Browse the repository at this point in the history
  7. skip create default indexes...

    ... When a Coordinates object is given to the Dataset constructor
    benbovy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    6f5114b View commit details
    Browse the repository at this point in the history
  8. invariant checks: maybe skip IndexVariable checks

    ... when check_default_indexes is False.
    benbovy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    e27830a View commit details
    Browse the repository at this point in the history
  9. add Coordinates tests

    benbovy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    1649fb8 View commit details
    Browse the repository at this point in the history
  10. more Coordinates tests

    benbovy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    298fccd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e8c627c View commit details
    Browse the repository at this point in the history
  12. fix mypy

    benbovy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    be86f87 View commit details
    Browse the repository at this point in the history
  13. assign_coords: do not create default indexes...

    ... when passing a Coordinates object
    benbovy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    75e2523 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    82f0fb2 View commit details
    Browse the repository at this point in the history
  15. clean-up

    benbovy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    883e67c View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    28e9861 View commit details
    Browse the repository at this point in the history
  17. fix tests: prevent index conflicts

    Do not extract multi-coordinate indexes from DataArray if they are
    overwritten or dropped (dimension coordinate).
    benbovy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    9a209a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Configuration menu
    Copy the full SHA
    4f337e3 View commit details
    Browse the repository at this point in the history
  2. more tests, docstrings, docs

    benbovy committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    43ddcf6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2437456 View commit details
    Browse the repository at this point in the history
  4. review copy

    benbovy committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e60570f View commit details
    Browse the repository at this point in the history
  5. another few tests

    benbovy committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    d01cf01 View commit details
    Browse the repository at this point in the history
  6. fix mypy

    benbovy committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    9fc49ff View commit details
    Browse the repository at this point in the history
  7. update what's new

    benbovy committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    7873c77 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e7998d1 View commit details
    Browse the repository at this point in the history
  9. do not copy indexes

    May corrupt multi-coordinate indexes.
    benbovy committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    f7ec33e View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Configuration menu
    Copy the full SHA
    b1a9688 View commit details
    Browse the repository at this point in the history
  2. fix sphinx directive

    benbovy committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    38fdf1e View commit details
    Browse the repository at this point in the history
  3. re-add coord indexes in merge (dataset constructor)

    This re-enables the optimization in deep_align that skips
    alignment for any alignable (DataArray) in a dict that
    matches an index key.
    benbovy committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    d9e9e34 View commit details
    Browse the repository at this point in the history
  4. create coords with default idx: try a cleaner impl

    Coordinate variables and indexes extracted from DataArrays should be
    merged more properly.
    benbovy committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    3999eff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d5d8233 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d2fcaa3 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. allow skip align for object(s) in merge_core

    This fixes the decrease in performance observed in Dataset creation
    benchmarks.
    
    When creating a new Dataset, the variables and indexes in `Coordinates`
    should already be aligned together so it doesn't need to go through the
    complex alignment logic once again. `Coordinates` indexes are still used
    to align data variables.
    benbovy committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    193dad3 View commit details
    Browse the repository at this point in the history
  2. fix mypy

    benbovy committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    84c77a4 View commit details
    Browse the repository at this point in the history
  3. what's new tweaks

    benbovy committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5e82d61 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c6409fd View commit details
    Browse the repository at this point in the history
  5. fix Coordinates._overwrite_indexes callback

    mypy was rightfully complaining. This callback is called from Aligner
    only, which passes the first two arguments and ignores the rest.
    benbovy committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    39294fc View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Configuration menu
    Copy the full SHA
    3fc1e8c View commit details
    Browse the repository at this point in the history
  2. remove merge_coords

    benbovy committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    8c65f85 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cf6fcbb View commit details
    Browse the repository at this point in the history
  4. review comments

    benbovy committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    6a6444f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    50cf057 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Configuration menu
    Copy the full SHA
    f5d1fe1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1759ac9 View commit details
    Browse the repository at this point in the history
  3. Fix circulat imports

    Illviljan committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    48f6950 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a789f6b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fa384f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Configuration menu
    Copy the full SHA
    7628cb2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8821f9 View commit details
    Browse the repository at this point in the history
  3. remove Coordinate alias of Variable

    Much water has flowed under the bridge since it has been renamed.
    benbovy committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    c71aadb View commit details
    Browse the repository at this point in the history
  4. fix groupby test

    benbovy committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    139b13a View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Configuration menu
    Copy the full SHA
    7ed6279 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d94357 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4a6e915 View commit details
    Browse the repository at this point in the history
  4. better comment

    benbovy committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    31f66b4 View commit details
    Browse the repository at this point in the history
  5. fix Self undefined error with python < 3.11

    Pyright displays an info message "Self is not valid in this context" but
    most important this should avoid runtime errors with python < 3.11.
    benbovy committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    4cb70d0 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    4ef5f17 View commit details
    Browse the repository at this point in the history