Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nczarr when libnetcdf>4.8.1 #7575

Merged
merged 1 commit into from
Mar 2, 2023
Merged

fix nczarr when libnetcdf>4.8.1 #7575

merged 1 commit into from
Mar 2, 2023

Conversation

malmans2
Copy link
Contributor

@malmans2 malmans2 commented Mar 1, 2023

User visible changes (including notable bug fixes) are documented in whats-new.rst
New functions/methods are listed in api.rst

The latest version of netcdf-c does not allow writing a NCZarr file without the xarray's _ARRAY_DIMENSIONS attribute.
Also, nczarr attributes are now lowercase.

@github-actions github-actions bot added io topic-backends topic-zarr Related to zarr storage library labels Mar 1, 2023
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should get that merged asap to get CI running again.

@headtr1ck headtr1ck added the plan to merge Final call for comments label Mar 1, 2023
@dcherian
Copy link
Contributor

dcherian commented Mar 2, 2023

Thanks @malmans2

@dcherian dcherian merged commit 463bc28 into pydata:main Mar 2, 2023
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 9, 2023
* main:
  Preserve `base` and `loffset` arguments in `resample` (pydata#7444)
  ignore the `pkg_resources` deprecation warning (pydata#7594)
  Update contains_cftime_datetimes to avoid loading entire variable array (pydata#7494)
  Support first, last with dask arrays (pydata#7562)
  update the docs environment (pydata#7442)
  Add xCDAT to list of Xarray related projects (pydata#7579)
  [pre-commit.ci] pre-commit autoupdate (pydata#7565)
  fix nczarr when libnetcdf>4.8.1 (pydata#7575)
  use numpys SupportsDtype (pydata#7521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io plan to merge Final call for comments topic-backends topic-zarr Related to zarr storage library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_open_nczarr failing
3 participants