Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs page on interoperability #7992

Merged
merged 32 commits into from
Oct 26, 2023
Merged

Docs page on interoperability #7992

merged 32 commits into from
Oct 26, 2023

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Jul 17, 2023 •
edited
Loading

Builds upon #7991 by adding a page to the internals enumerating all the different ways in which xarray is interoperable.

Would be nice if #6975 were merged so that I could link to it from this new page.

@trexfeathers
Copy link

@pp-mo 👀

max-sixty
max-sixty approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

doc/internals/interoperability.rst Outdated Show resolved Hide resolved
doc/internals/interoperability.rst
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool page!

@max-sixty
Copy link
Collaborator

This just came up on my notifications — looks great — shall we merge?

@TomNicholas
Copy link
Member Author

You must be getting a lot of notifications if you got one just because I committed here!
🤯

Yes great I was just waiting for an approval - will merge shortly.

TomNicholas and others added 2 commits October 4, 2023 15:17
@TomNicholas @max-sixty
reword lack of support for subclassing
b2b8338 
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
@TomNicholas
Merge branch 'main' into docs_interoperability
1f9c17c
@TomNicholas TomNicholas enabled auto-merge (squash) October 4, 2023 19:23
@TomNicholas TomNicholas merged commit 78f7491 into pydata:main Oct 26, 2023
27 checks passed
@TomNicholas TomNicholas deleted the docs_interoperability branch October 26, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Illviljan Illviljan Illviljan left review comments

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
needs review topic-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomNicholas @trexfeathers @max-sixty @Illviljan