Use variable name in all exceptions raised in as_variable
#7995
Conversation
This is more consistent with the other exceptions raised in this function, and helps to more quickly diagnose issues when e.g. creating datasets
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
|
Thank you @ZedThree ! Also good to see you on here :)
I say yes, and then you get credit in the changelog too. |
|
An easy first fix! 😄 Done! Added to |
There was a problem hiding this comment.
An easy first fix!
Great! There are almost certainly other places which could have clearer error messages like this FYI, especially after #5692 and related changes.
Done! Added to internal changes, though I guess it would also work under documentation
Absolutely fine.
|
This is a great addition. Thanks @ZedThree ! Welcome to Xarray. |
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
…lazy-array * upstream/main: (153 commits) Add HDF5 Section to read/write docs page (pydata#8012) [pre-commit.ci] pre-commit autoupdate (pydata#8014) Update interpolate_na in dataset.py (pydata#7974) improved docstring of to_netcdf (issue pydata#7127) (pydata#7947) Expose "Coordinates" as part of Xarray's public API (pydata#7368) Core team member guide (pydata#7999) join together duplicate entries in the text `repr` (pydata#7225) Update copyright year in README (pydata#8007) Allow opening datasets with nD dimenson coordinate variables. (pydata#7989) Move whats-new entry [pre-commit.ci] pre-commit autoupdate (pydata#7997) Add documentation on custom indexes (pydata#6975) Use variable name in all exceptions raised in `as_variable` (pydata#7995) Bump pypa/gh-action-pypi-publish from 1.8.7 to 1.8.8 (pydata#7994) New whatsnew section Remove future release notes before this release Update whats-new.rst for new release (pydata#7993) Remove hue_style from plot1d docstring (pydata#7925) Add new what's new section (pydata#7986) Release summary for v2023.07.0 (pydata#7979) ...
This is more consistent with the other exceptions raised in this function, and helps to more quickly diagnose issues when e.g. creating datasets.
whats-new.rstIs this a large enough change to warrant an entry in
whats-new?