Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to maybe_promote in dtypes.py #8243

Merged
merged 12 commits into from
Sep 28, 2023
Merged

Add type hints to maybe_promote in dtypes.py #8243

merged 12 commits into from
Sep 28, 2023

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Sep 27, 2023 •
edited
Loading

Reducing type errors in #8241

@Illviljan Illviljan changed the title Add type hints to maybe_promote Add type hints to maybe_promote in dtypes.py Sep 28, 2023
@Illviljan Illviljan marked this pull request as ready for review September 28, 2023 17:00
@Illviljan Illviljan added the plan to merge Final call for comments label Sep 28, 2023
@Illviljan Illviljan merged commit dbcf6a7 into pydata:main Sep 28, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Illviljan @max-sixty