Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add open_datatree to xarray #8697

Merged
merged 31 commits into from
Feb 14, 2024
Merged

add open_datatree to xarray #8697

merged 31 commits into from
Feb 14, 2024

Commits on Jan 29, 2024

  1. Merge remote-tracking branch 'prepared-datatree/main' into mhs/import… 

    …-datatree-attempt2
    @flamingbear
    flamingbear committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    0266b63 View commit details
    Browse the repository at this point in the history

  2. DAS-2060: Skips datatree_ CI 

    Adds additional ignore to mypy

Adds additional ignore to doctests

Excludes xarray/datatree_ from all pre-commmit.ci
    @flamingbear
    flamingbear committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    3899b06 View commit details
    Browse the repository at this point in the history

  3. DAS-2070: Migrate open_datatree into xarray. 

    First stab. Will need to add/move tests.
    @flamingbear
    flamingbear committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    d5b80f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. DAS-2060: replace relative import of datatree to library

    @flamingbear
    flamingbear committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0c62960 View commit details
    Browse the repository at this point in the history

  2. DAS-2060: revert the exporting of NodePath from datatree 

    I mistakenly thought we wanted to use the hidden version of datatree_ and we do not.
    @flamingbear
    flamingbear committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a523d50 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge branch 'main' into mhs/DAS-2060/open_datatree

    @flamingbear
    flamingbear committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    1e5e433 View commit details
    Browse the repository at this point in the history

  2. Don't expose open_datatree at top level 

    We do not want to expose open_datatree at top level until all of the code is migrated.
    @flamingbear
    flamingbear committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e687e4a View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Point datatree imports to xarray.datatree_.datatree

    @flamingbear
    flamingbear committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    4e05d5c View commit details
    Browse the repository at this point in the history

  2. Updates function signatures for mypy.

    @flamingbear
    flamingbear committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    77405d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Move io tests, remove undefined reference to documentation. 

    Also starts fixing simple mypy errors
    @flamingbear
    flamingbear committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    81b425f View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Pass bare-minimum tests.

    @flamingbear
    flamingbear committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    3c5bcda View commit details
    Browse the repository at this point in the history

  2. Update pyproject.toml to exclude imported datatree_ modules. 

    Add some typing for mygrated tests.
Adds display_expand_groups to core options.
    @flamingbear
    flamingbear committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9f89256 View commit details
    Browse the repository at this point in the history

  3. Adding back type ignores 

    This is cargo-cult.  I wonder if there's a different CI test that wanted these
and since this is now excluded at the top level.  I'm putting them back until
migration into main codebase.
    @flamingbear
    flamingbear committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a4bad61 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Refactor open_datatree back together. 

    puts common parts in common.
    @flamingbear
    flamingbear committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e4f0374 View commit details
    Browse the repository at this point in the history

  2. Removes TODO comment

    @flamingbear
    flamingbear committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    3b1224c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into mhs/open_datatree

    @flamingbear
    flamingbear authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e447900 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch 'main' into mhs/open_datatree

    @flamingbear
    flamingbear authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    352222d View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Merge branch 'main' into mhs/open_datatree

    @flamingbear
    flamingbear authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9745864 View commit details
    Browse the repository at this point in the history

  2. typo fix 

    Co-authored-by: Tom Nicholas <tom@cworthy.org>
    @flamingbear @TomNicholas
    flamingbear and TomNicholas authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    20d8691 View commit details
    Browse the repository at this point in the history

  3. typo 2 

    Co-authored-by: Tom Nicholas <tom@cworthy.org>
    @flamingbear @TomNicholas
    flamingbear and TomNicholas authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    221bc8c View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b74764e View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Merge branch 'main' into mhs/open_datatree

    @flamingbear
    flamingbear authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    6498acc View commit details
    Browse the repository at this point in the history

  2. Call raised exception

    @flamingbear
    flamingbear committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    4280d30 View commit details
    Browse the repository at this point in the history

  3. Add unpacking notation to kwargs

    @flamingbear
    flamingbear committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    8c54465 View commit details
    Browse the repository at this point in the history

  4. Use final location for DataTree doc strings 

    Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
    @flamingbear @keewis
    flamingbear and keewis authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    afba7ba View commit details
    Browse the repository at this point in the history

  5. fix comment from open_dataset to open_datatree 

    Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
    @flamingbear @keewis
    flamingbear and keewis authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    aab1744 View commit details
    Browse the repository at this point in the history

  6. Revert "fix comment from open_dataset to open_datatree" 

    This reverts commit aab1744.
    @flamingbear
    flamingbear committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    5b48973 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Change sphynx link from meth to func

    @flamingbear
    flamingbear committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    c6bb18a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mhs/open_datatree

    @flamingbear
    flamingbear authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    4d306c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Update whats-new.rst

    @flamingbear
    flamingbear committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d386ed3 View commit details
    Browse the repository at this point in the history

  2. Fix what-new.rst formatting.

    @flamingbear
    flamingbear committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    e291587 View commit details
    Browse the repository at this point in the history