-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate datatree.py module into xarray.core. #8789
Merged
TomNicholas
merged 27 commits into
pydata:main
from
flamingbear:DAS-2062-migrate-datatree-module-pr
Mar 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ed47ffd
Migrate datatree.py module into xarray.core.
owenlittlejohns 0784196
Add correct PR reference to whats-new.rst.
owenlittlejohns 647582d
Revert to using Union in datatree.py.
owenlittlejohns 26f3e61
Catch remaining unfixed import path.
owenlittlejohns 5e575d7
Fix easier mypy annotations in datatree.py and test_datatree.py.
owenlittlejohns 6b7a15f
Straggling mypy change in datatree.py.
owenlittlejohns 738bf28
datatree.py comment clean-up.
owenlittlejohns 6eaa021
More mypy corrections in datatree.py and test_datatree.py.
owenlittlejohns 0397e67
Removes unnecessary dict wrapper.
flamingbear c45c56a
DAS-2062: renames as_array -> to_dataarray
flamingbear b333b1d
DAS-2062: Updates doc string for Datatree.to_zarr
flamingbear 34e00bd
DAS-2062: reverts what-new.rst
flamingbear c171470
Merge branch 'main' into DAS-2062-migrate-datatree-module-pr
flamingbear a0d3702
DAS-2062: clarify wording in comment.
flamingbear 869103b
Change Datatree.to_dataarray to call correctly
flamingbear 379bc5c
Merge branch 'main' into DAS-2062-migrate-datatree-module-pr
flamingbear 12590fb
Clarify DataTree's names are still strings now.
flamingbear 8c3ba13
Merge branch 'main' into DAS-2062-migrate-datatree-module-pr
dcherian 5cc7c41
Merge branch 'main' into DAS-2062-migrate-datatree-module-pr
flamingbear 4a53979
DAS-2062: Cast k explicitly to str for typing.
flamingbear ffa5f71
Ignore mypy errors for DataTree.ds assignment.
owenlittlejohns 881af78
Fix DataTree.update type hint.
owenlittlejohns 3fc4796
Final mypy issue - ignore DataTree.get override.
owenlittlejohns 14b5c02
Update contributors in whats-new.rst
owenlittlejohns 3aaf837
Merge branch 'main' into DAS-2062-migrate-datatree-module-pr
owenlittlejohns ce68416
Fix GitHub handle.
owenlittlejohns 0ae54cb
Merge branch 'main' into DAS-2062-migrate-datatree-module-pr
flamingbear File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
Sorry, something went wrong. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks - I added these changes in: 2c5e54c |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomNicholas should this have been kept out of breaking changes? mostly because it's not actually released? Wasn't sure where I should keep it. reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we never had a need before for "breaking changes that aren't breaking yet but will be, but only relevant for previous users of another package" 😅
These datatree breaking changes really only need to be written down somewhere, even a GH issue, so that we can point to them all at once when it comes time to do the grand reveal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#8807 and reverted. 😬