Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement setitem syntax for .oindex and .vindex properties #8845

Merged

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Mar 16, 2024

xarray/core/indexing.py Outdated Show resolved Hide resolved
xarray/core/indexing.py Outdated Show resolved Hide resolved
xarray/core/indexing.py Outdated Show resolved Hide resolved
@andersy005
Copy link
Member Author

thank you for the feedback, @dcherian! when you get a chance, this is ready for another round of review

@dcherian
Copy link
Contributor

👏 👏

For the next step, are you thinking of tackling backwards compatibility with backends, or migrating the Indexer and getitem, setitem to named_array/

@dcherian dcherian merged commit 79272c3 into pydata:main Mar 19, 2024
28 of 29 checks passed
@andersy005 andersy005 deleted the expand-use-of-oindex-vindex-in-setitem branch March 19, 2024 20:58
@andersy005
Copy link
Member Author

For the next step, are you thinking of tackling backwards compatibility with backends, or migrating the Indexer and getitem, setitem to named_array/

i spoke with @maxrjones yesterday, and he plans to tackle the backwards compatibility with backends later this week. meanwhile i'm going to start looking into the migration of the indexing functionality to namedarray

dcherian added a commit to kmsquire/xarray that referenced this pull request Mar 21, 2024
* upstream/main: (765 commits)
  increase typing annotations coverage in `xarray/core/indexing.py` (pydata#8857)
  pandas 3 MultiIndex fixes (pydata#8847)
  FIX: adapt handling of copy keyword argument in scipy backend for numpy >= 2.0dev (pydata#8851)
  FIX: do not cast _FillValue/missing_value in CFMaskCoder if _Unsigned is provided (pydata#8852)
  Implement setitem syntax for `.oindex` and `.vindex` properties (pydata#8845)
  Support pandas copy-on-write behaviour (pydata#8846)
  correctly encode/decode _FillValues/missing_values/dtypes for packed data (pydata#8713)
  Expand use of `.oindex` and `.vindex` (pydata#8790)
  Return a dataclass from Grouper.factorize (pydata#8777)
  [skip-ci] Fix upstream-dev env (pydata#8839)
  Add dask-expr for windows envs (pydata#8837)
  [skip-ci] Add dask-expr dependency to doc.yml (pydata#8835)
  Add `dask-expr` to environment-3.12.yml (pydata#8827)
  Make list_chunkmanagers more resilient to broken entrypoints (pydata#8736)
  Do not attempt to broadcast when global option ``arithmetic_broadcast=False`` (pydata#8784)
  try to get the `upstream-dev` CI to complete again (pydata#8823)
  Bump the actions group with 1 update (pydata#8818)
  Update documentation for clarity (pydata#8817)
  DOC: link to zarr.convenience.consolidate_metadata (pydata#8816)
  Refactor Grouper objects (pydata#8776)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants