Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: Fix numbagg or bottlekneck skip #9034

Merged
merged 1 commit into from
May 18, 2024
Merged

TEST: Fix numbagg or bottlekneck skip #9034

merged 1 commit into from
May 18, 2024

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented May 18, 2024 •
edited
Loading

It only seems to be used in 1 place:

$ rg requires_numbagg_or_bottleneck
xarray/tests/test_missing.py
28:    requires_numbagg_or_bottleneck,
416:@requires_numbagg_or_bottleneck

xarray/tests/__init__.py
147:requires_numbagg_or_bottleneck = pytest.mark.skipif(
  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

hmaarrfk
hmaarrfk commented May 18, 2024
View reviewed changes
xarray/tests/__init__.py
@@ -145,7 +145,7 @@ def _importorskip(
)
has_numbagg_or_bottleneck = has_numbagg or has_bottleneck
requires_numbagg_or_bottleneck = pytest.mark.skipif(
not has_scipy_or_netCDF4, reason="requires scipy or netCDF4"
not has_numbagg_or_bottleneck, reason="requires numbagg or bottlekneck"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it was copied from the code above without mod. small "typo" fix.

@hmaarrfk hmaarrfk changed the title Fix numbagg or bottlekneck skip TEST: Fix numbagg or bottlekneck skip May 18, 2024
@max-sixty
Copy link
Collaborator

Thanks a lot @hmaarrfk !

@max-sixty max-sixty merged commit d0e96b2 into pydata:main May 18, 2024
28 checks passed
andersy005 added a commit that referenced this pull request May 21, 2024
@andersy005
Merge branch 'main' into backend-indexing
45ceac6 
* main:
  Bump codecov/codecov-action from 4.3.1 to 4.4.0 in the actions group (#9036)
  Use ME in test_plot instead of M (#9035)
  Fix numbagg or bottlekneck skip (#9034)
  [skip-ci] min_deps_check: show age of required pkg on error (#9025)
  attempt to get colour output in CI (#9031)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmaarrfk @max-sixty