Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user survey announcement to docs #9101

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Add user survey announcement to docs #9101

merged 3 commits into from
Jun 12, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Jun 12, 2024

Updating the doc announcement banner to include a link to the active user survey: https://forms.gle/pDRtaTx6GtNn91959

This is already live on our landing page: https://xarray.dev

See also #9076

@jhamman jhamman requested a review from dcherian June 12, 2024 15:31
@TomNicholas
Copy link
Member

👍 to this PR

But is this the colors it renders with for everyone else? This kind of hurts my eyes 👀

Screenshot 2024-06-12 at 12 10 35 PM

@kmuehlbauer
Copy link
Contributor

But is this the colors it renders with for everyone else? This kind of hurts my eyes 👀

It's looking great in dark mode. But, yeah, in light mode it really is no eye candy at all.

@jhamman
Copy link
Member Author

jhamman commented Jun 12, 2024

I believe this is a bug in the readthedocs dev build. You can check out another PR build (e.g. https://xray--9099.org.readthedocs.build/en/9099/) and see the same formatting issue.

Might we assume that this will not propagate to the production build?

@TomNicholas
Copy link
Member

Might we assume that this will not propagate to the production build?

Just push it and find out 🤷 The formatting is a separate issue from this issue of adding the survey banner anyway.

@keewis
Copy link
Collaborator

keewis commented Jun 12, 2024

the current banner looks just as bad on latest, but not on stable. I'd guess we have a changed dependency (probably sphinx-book-theme or pydata-sphinx-theme).

@keewis keewis mentioned this pull request Jun 12, 2024
2 tasks
@dcherian dcherian merged commit 2e0dd6f into main Jun 12, 2024
26 of 28 checks passed
@dcherian dcherian deleted the user-survey-docs branch June 12, 2024 18:58
@jhamman
Copy link
Member Author

jhamman commented Jun 12, 2024

I happened to be standing next to @choldgraf at the CZI meeting when I reviewed @dcherian's fix. Chris thinks this was broken by a change in the pydata theme css.

dcherian added a commit to dcherian/xarray that referenced this pull request Jun 13, 2024
* upstream/main:
  [skip-ci] Try fixing hypothesis CI trigger (pydata#9112)
  Undo custom padding-top. (pydata#9107)
  add remaining core-dev citations [skip-ci][skip-rtd] (pydata#9110)
  Add user survey announcement to docs (pydata#9101)
  skip the `pandas` datetime roundtrip test with `pandas=3.0` (pydata#9104)
  Adds Matt Savoie to CITATION.cff (pydata#9103)
  [skip-ci] Fix skip-ci for hypothesis (pydata#9102)
  open_datatree performance improvement on NetCDF, H5, and Zarr files (pydata#9014)
  Migrate datatree io.py and common.py into xarray/core (pydata#9011)
  Micro optimizations to improve indexing (pydata#9002)
  (fix): don't handle time-dtypes as extension arrays in `from_dataframe` (pydata#9042)
dcherian added a commit to mraspaud/xarray that referenced this pull request Jun 13, 2024
* main:
  new whats-new section (pydata#9115)
  release v2024.06.0 (pydata#9113)
  release notes for 2024.06.0 (pydata#9092)
  [skip-ci] Try fixing hypothesis CI trigger (pydata#9112)
  Undo custom padding-top. (pydata#9107)
  add remaining core-dev citations [skip-ci][skip-rtd] (pydata#9110)
  Add user survey announcement to docs (pydata#9101)
  skip the `pandas` datetime roundtrip test with `pandas=3.0` (pydata#9104)
  Adds Matt Savoie to CITATION.cff (pydata#9103)
  [skip-ci] Fix skip-ci for hypothesis (pydata#9102)
  open_datatree performance improvement on NetCDF, H5, and Zarr files (pydata#9014)
andersy005 pushed a commit that referenced this pull request Jun 14, 2024
* Add user survey announcement to docs

* FIx styling

---------

Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants