-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the cloud storage credentials when opening a datatree from ZarrStore (#9197) #9198
base: main
Are you sure you want to change the base?
Set the cloud storage credentials when opening a datatree from ZarrStore (#9197) #9198
Conversation
datatree from the ZarrStore (Issue pydata#9197)
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
for more information, see https://pre-commit.ci
This look good, but I'm concerned that it might break again in the future if we don't add any tests. Is there any way we could test that |
Hi Stephan, |
Is this made redundant by all the extra kwargs that were passed through by #9377? That PR also passes through |
Actually this PR is still needed because xarray/xarray/backends/zarr.py Line 1259 in 19a0428
storage_options .
The fix here ideally would refactor to use |
@vlevasseur073 please try this with |
whats-new.rst
api.rst